fix(ci): Preserve source SPM products in samples#7962
Merged
philprime merged 1 commit intoMay 28, 2026
Merged
Conversation
Run package prep for every sample build and keep source-backed package products while stripping binary targets for release branch builds.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## philprime/objc-wrapper-sdk-6342-2 #7962 +/- ##
=======================================================================
+ Coverage 86.525% 86.531% +0.005%
=======================================================================
Files 549 549
Lines 31593 31592 -1
Branches 13010 13002 -8
=======================================================================
+ Hits 27336 27337 +1
+ Misses 4207 4206 -1
+ Partials 50 49 -1 see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b1f0d15 | 1232.21 ms | 1264.13 ms | 31.91 ms |
| b5de00c | 1223.96 ms | 1252.17 ms | 28.21 ms |
| 7c3a7fd | 1223.64 ms | 1242.66 ms | 19.02 ms |
| 6884ba9 | 1222.98 ms | 1254.19 ms | 31.21 ms |
| e886b8e | 1230.16 ms | 1255.70 ms | 25.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b1f0d15 | 24.14 KiB | 1.17 MiB | 1.14 MiB |
| b5de00c | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| 7c3a7fd | 24.14 KiB | 1.16 MiB | 1.14 MiB |
| 6884ba9 | 24.14 KiB | 1.17 MiB | 1.15 MiB |
| e886b8e | 24.14 KiB | 1.16 MiB | 1.13 MiB |
420e4e1
into
philprime/objc-wrapper-sdk-6342-2
206 of 254 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep release-branch sample builds from resolving unpublished binary target URLs while preserving the local source package products used by samples.
This is stacked on #7918. That PR adds the iOS-ObjectiveCpp-NoModules sample, which depends on the local SPM product SentryObjC. The existing workflow only ran package prep for DistributionSample, so other sample schemes could still hit Package.swift binary target URLs during workspace package resolution on release branches.
This runs binary target stripping for every sample build and keeps source-backed products appended later in Package.swift, including SentrySPM and SentryObjC.
Verified locally by running prepare-package.sh against a temporary Package.swift copy and parsing the result with swift package dump-package. The generated manifest has no binary targets and still exposes SentryDistribution, SentrySPM, and SentryObjC.
#skip-changelog