Skip to content

feat: Add install_groups support#7278

Merged
noahsmartin merged 1 commit intomainfrom
installGroupsDistribution
Jan 26, 2026
Merged

feat: Add install_groups support#7278
noahsmartin merged 1 commit intomainfrom
installGroupsDistribution

Conversation

@noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Jan 23, 2026

Adds this new field to support "groups"

Closes #7279

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • Add install_groups support by noahsmartin in #7278

Bug Fixes 🐛

  • Prevent deadlock in SentryReachability by notifying observers outside the lock by itaybre in #7246

Internal Changes 🔧

  • (release) Fix changelog-preview permissions by BYK in #7262
  • Fix SwiftLint script warning by itaybre in #7267
  • Convert SentryNSDataSwizzling and SentryNSFileManagerSwizzling to Swift by itaybre in #7209
  • Convert SentrySessionReplayIntegration to Swift by itaybre in #7102
  • Fix incomplete comment by itaybre in #7239

Other

  • test: Fix SentryDestinationTests to handle array type for tags by itaybre in #7240

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2348d85

@noahsmartin noahsmartin added the ready-to-merge Use this label to trigger all PR workflows label Jan 23, 2026
@noahsmartin noahsmartin force-pushed the installGroupsDistribution branch from 4ab6cec to cf29e5a Compare January 23, 2026 22:38
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1206.20 ms 1235.89 ms 29.69 ms
Size 24.14 KiB 1.08 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bed2eb7 1215.88 ms 1247.14 ms 31.27 ms
58a9225 1211.40 ms 1238.88 ms 27.48 ms
5d67f5d 1225.33 ms 1262.76 ms 37.43 ms
86b8951 1211.20 ms 1247.92 ms 36.72 ms
ffe0649 1213.35 ms 1248.64 ms 35.29 ms
29b6704 1216.31 ms 1251.91 ms 35.60 ms
45eb835 1216.00 ms 1248.48 ms 32.48 ms
387fbe4 1226.19 ms 1251.98 ms 25.79 ms
a1a9260 1192.15 ms 1229.80 ms 37.64 ms
1d0feed 1213.31 ms 1247.44 ms 34.14 ms

App size

Revision Plain With Sentry Diff
bed2eb7 24.14 KiB 1.07 MiB 1.04 MiB
58a9225 24.14 KiB 1.06 MiB 1.04 MiB
5d67f5d 24.14 KiB 1.06 MiB 1.04 MiB
86b8951 24.14 KiB 1.08 MiB 1.06 MiB
ffe0649 24.14 KiB 1.06 MiB 1.04 MiB
29b6704 24.14 KiB 1.06 MiB 1.04 MiB
45eb835 24.14 KiB 1.07 MiB 1.04 MiB
387fbe4 24.14 KiB 1.07 MiB 1.04 MiB
a1a9260 24.14 KiB 1.08 MiB 1.06 MiB
1d0feed 24.14 KiB 1.05 MiB 1.03 MiB

Previous results on branch: installGroupsDistribution

Startup times

Revision Plain With Sentry Diff
a5e2a1f 1219.41 ms 1251.68 ms 32.27 ms
cbe7b71 1227.02 ms 1263.85 ms 36.83 ms

App size

Revision Plain With Sentry Diff
a5e2a1f 24.14 KiB 1.08 MiB 1.06 MiB
cbe7b71 24.14 KiB 1.08 MiB 1.06 MiB

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.035%. Comparing base (edcda5a) to head (2348d85).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #7278       +/-   ##
=============================================
+ Coverage   84.785%   85.035%   +0.250%     
=============================================
  Files          470       470               
  Lines        28387     28387               
  Branches     12460     12463        +3     
=============================================
+ Hits         24068     24139       +71     
+ Misses        4270      4200       -70     
+ Partials        49        48        -1     

see 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edcda5a...2348d85. Read the comment docs.

@noahsmartin noahsmartin force-pushed the installGroupsDistribution branch 2 times, most recently from 4d75a08 to 981d8f5 Compare January 26, 2026 17:07
@noahsmartin noahsmartin force-pushed the installGroupsDistribution branch from 981d8f5 to 2348d85 Compare January 26, 2026 17:17
@noahsmartin noahsmartin merged commit b0c71c8 into main Jan 26, 2026
241 of 243 checks passed
@noahsmartin noahsmartin deleted the installGroupsDistribution branch January 26, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Use this label to trigger all PR workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add install_groups support

2 participants