fix: Change parameter of SDKInfo.initWithOptions to be nullable#4968
Merged
fix: Change parameter of SDKInfo.initWithOptions to be nullable#4968
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8aec30e | 1244.71 ms | 1262.20 ms | 17.49 ms |
| 313b1d9 | 1240.18 ms | 1258.44 ms | 18.26 ms |
| 649d940 | 1231.69 ms | 1250.76 ms | 19.06 ms |
| 1734d1b | 1198.69 ms | 1221.62 ms | 22.93 ms |
| ed1c644 | 1225.92 ms | 1241.24 ms | 15.33 ms |
| 99fe600 | 1226.16 ms | 1236.88 ms | 10.71 ms |
| 887502e | 1225.40 ms | 1249.92 ms | 24.51 ms |
| 2de284c | 1234.92 ms | 1254.45 ms | 19.53 ms |
| 3f6c30b | 1252.98 ms | 1266.22 ms | 13.24 ms |
| 2b19b82 | 1226.73 ms | 1243.27 ms | 16.53 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8aec30e | 21.58 KiB | 616.76 KiB | 595.18 KiB |
| 313b1d9 | 22.85 KiB | 414.11 KiB | 391.26 KiB |
| 649d940 | 21.58 KiB | 695.36 KiB | 673.78 KiB |
| 1734d1b | 21.58 KiB | 418.82 KiB | 397.24 KiB |
| ed1c644 | 21.58 KiB | 670.39 KiB | 648.81 KiB |
| 99fe600 | 21.90 KiB | 708.13 KiB | 686.23 KiB |
| 887502e | 21.58 KiB | 704.26 KiB | 682.67 KiB |
| 2de284c | 21.58 KiB | 542.39 KiB | 520.80 KiB |
| 3f6c30b | 22.85 KiB | 408.88 KiB | 386.03 KiB |
| 2b19b82 | 21.58 KiB | 542.18 KiB | 520.60 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4968 +/- ##
=============================================
+ Coverage 92.396% 92.504% +0.107%
=============================================
Files 666 666
Lines 78979 78996 +17
Branches 27738 28602 +864
=============================================
+ Hits 72974 73075 +101
+ Misses 5914 5824 -90
- Partials 91 97 +6
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes the parameter
SDKInfo.initWithOptionsto be nullable.💡 Motivation and Context
The options can be nullable and will throw if doing something like
options.sessionReplay.enableExperimentalViewRenderer.This change is required for #4940.
💚 How did you test it?
Added a unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps