feat: add threshold to always log fatal logs#4707
Merged
Conversation
Contributor
|
9 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4707 +/- ##
=============================================
+ Coverage 91.149% 91.207% +0.057%
=============================================
Files 623 624 +1
Lines 71759 72095 +336
Branches 25950 26227 +277
=============================================
+ Hits 65408 65756 +348
+ Misses 6257 6240 -17
- Partials 94 99 +5
... and 61 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
brustolin
reviewed
Jan 13, 2025
brustolin
approved these changes
Jan 14, 2025
Contributor
brustolin
left a comment
There was a problem hiding this comment.
LGTM
I will leave the guard thing to your best judgement.
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b695b61 | 1221.71 ms | 1249.18 ms | 27.47 ms |
| 0589699 | 1243.25 ms | 1252.60 ms | 9.35 ms |
| 3ea21f5 | 1250.80 ms | 1258.88 ms | 8.08 ms |
| 407ff99 | 1190.89 ms | 1237.18 ms | 46.29 ms |
| 904d7fa | 1225.73 ms | 1249.22 ms | 23.49 ms |
| c471221 | 1224.16 ms | 1241.59 ms | 17.43 ms |
| 1928267 | 1200.94 ms | 1227.17 ms | 26.23 ms |
| 09311b6 | 1238.67 ms | 1255.04 ms | 16.37 ms |
| ed49f0c | 1215.94 ms | 1245.63 ms | 29.69 ms |
| 973d574 | 1240.86 ms | 1255.83 ms | 14.98 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b695b61 | 21.90 KiB | 707.65 KiB | 685.75 KiB |
| 0589699 | 21.58 KiB | 656.60 KiB | 635.02 KiB |
| 3ea21f5 | 22.84 KiB | 402.63 KiB | 379.78 KiB |
| 407ff99 | 20.76 KiB | 427.86 KiB | 407.10 KiB |
| 904d7fa | 20.76 KiB | 432.87 KiB | 412.11 KiB |
| c471221 | 22.85 KiB | 413.89 KiB | 391.04 KiB |
| 1928267 | 22.30 KiB | 730.78 KiB | 708.47 KiB |
| 09311b6 | 21.58 KiB | 654.67 KiB | 633.09 KiB |
| ed49f0c | 21.58 KiB | 632.13 KiB | 610.55 KiB |
| 973d574 | 21.58 KiB | 542.38 KiB | 520.80 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Introduces a new constant in
SentryLogto configure a log level that will always be logged.💡 Motivation and Context
Closes #4467
💚 How did you test it?
I added a statement
SENTRY_LOG_FATAL(@"test")in the SDK install code and checked if it gets printed.📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.🔮 Next steps
none