Skip to content

feat: Create transaction from UI events#1791

Merged
brustolin merged 11 commits intofeat/ui-transactionsfrom
feat/ui-transactions-continuation
May 12, 2022
Merged

feat: Create transaction from UI events#1791
brustolin merged 11 commits intofeat/ui-transactionsfrom
feat/ui-transactions-continuation

Conversation

@brustolin
Copy link
Copy Markdown
Contributor

@brustolin brustolin commented Apr 29, 2022

📜 Description

Creates transactions when a control sends an action to the application, like button clicks and switch toggles.

💡 Motivation and Context

Part of #1784

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

#skip-changelog

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 29, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against a6f2f87

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 30, 2022

Codecov Report

Merging #1791 (a6f2f87) into feat/ui-transactions (df7eaf7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           feat/ui-transactions    #1791      +/-   ##
========================================================
+ Coverage                 91.75%   91.79%   +0.04%     
========================================================
  Files                       200      200              
  Lines                      9166     9207      +41     
========================================================
+ Hits                       8410     8452      +42     
+ Misses                      756      755       -1     
Impacted Files Coverage Δ
Sources/Sentry/include/SentryTracer.h 100.00% <ø> (ø)
Sources/Sentry/Public/SentryOptions.h 100.00% <100.00%> (ø)
Sources/Sentry/SentryOptions.m 99.57% <100.00%> (+<0.01%) ⬆️
Sources/Sentry/SentryPerformanceTracker.m 100.00% <100.00%> (ø)
Sources/Sentry/SentrySwizzleWrapper.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryUIEventTrackingIntegration.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryProfilingLogging.mm 0.00% <0.00%> (-53.58%) ⬇️
Sources/Sentry/SentryInstallation.m 86.95% <0.00%> (-8.70%) ⬇️
Sources/Sentry/SentryMachLogging.cpp 0.00% <0.00%> (-2.06%) ⬇️
Sources/Sentry/SentryCoreDataTrackingIntegration.m 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7eaf7...a6f2f87. Read the comment docs.

Copy link
Copy Markdown
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@brustolin
Copy link
Copy Markdown
Contributor Author

Hey @philipphofmann. besides the integration tests that I don't know why they are falling, I think this PR is good to merge so you can finish the other PR.

@philipphofmann
Copy link
Copy Markdown
Member

Hey @philipphofmann. besides the integration tests that I don't know why they are falling, I think this PR is good to merge so you can finish the other PR.

Feel free to merge.

@brustolin brustolin merged commit 600930f into feat/ui-transactions May 12, 2022
@brustolin brustolin deleted the feat/ui-transactions-continuation branch May 12, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants