Merged
Conversation
Add maxCacheItems to SentryOptions to make the number of maximum envelopes to keep in the cache configurable. Fixes GH-899
bruno-garcia
approved these changes
Mar 24, 2021
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
LGTM but I raised a discussion about the value. 30's been our standard so far but since it had in-memory storage in mind, maybe we reconsider?
Member
Author
@bruno-garcia I'm also fine with increasing this, but it should be consistent across SDKs. Currently, we have 30 on Android and .NET. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Add maxCacheItems to SentryOptions to make the number of maximum envelopes
to keep in the cache configurable.
💡 Motivation and Context
Fixes GH-899
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps