fix: Free memory returned by backtrace_symbols() in debug builds (#3202)

indragiek · web-flow · commit ca91a5c381f8 · 2023-08-03T14:27:38.000-07:00
* fix: Free memory returned by backtrace_symbols() in debug builds This code is only compiled in debug builds, but we were forgetting to `free` the pointer returned by `backtrace_symbols`. The documentation (https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/backtrace_symbols.3.html) says: > It is allocated using malloc() and should be released using free() * Update CHANGELOG.md
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 ### Fixes
  
 - Remove linker settings from Package.swift (#3188)
+- Free memory returned by backtrace_symbols() in debug builds ([#3202](https://github.com/getsentry/sentry-cocoa/pull/3202))
 
 ## 8.9.3
 
diff --git a/Sources/Sentry/Profiling/SentryProfilerState.mm b/Sources/Sentry/Profiling/SentryProfilerState.mm
@@ -129,6 +129,9 @@ - (void)appendBacktrace:(const Backtrace &)backtrace
                 [stack addObject:frameIndex];
             }
         }
+#    if defined(DEBUG)
+        free(symbols);
+#    endif
 
         const auto sample = [[SentrySample alloc] init];
         sample.absoluteTimestamp = backtrace.absoluteTimestamp;

Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,9 @@ - (void)appendBacktrace:(const Backtrace &)backtrace`
`129`	`129`	`[stack addObject:frameIndex];`
`130`	`130`	`}`
`131`	`131`	`}`
	`132`	`+# if defined(DEBUG)`
	`133`	`+ free(symbols);`
	`134`	`+# endif`
`132`	`135`
`133`	`136`	`const auto sample = [[SentrySample alloc] init];`
`134`	`137`	`sample.absoluteTimestamp = backtrace.absoluteTimestamp;`