fix(sourcemaps): Display injection errors#2775
Merged
szokeasaurusrex merged 1 commit intomasterfrom Sep 22, 2025
Merged
Conversation
We have been generating these error messages, but we never print them, even though it seems like we probably mean to be printing them. Fixes #2774 Fixes [CLI-170](https://linear.app/getsentry/issue/CLI-170/sourcemap-injection-errors-never-displayed)
eead738 to
09e715a
Compare
lcian
approved these changes
Sep 22, 2025
Member
There was a problem hiding this comment.
Nice, seems useful to print the errors.
I wonder, does the user know what do to in order to resolve the issue? Would it make sense to display some more info about the issue and/or how to resolve it?
Or is it something that CLI will be able to fix on its own?
Or another possibility, is this just warnings that we want to see for bug reports?
Member
Author
|
@lcian I guess we will see whether users are able to figure out what to do based on the error message. To be honest, I am not completely sure whether they will be able to figure it out. But, we can see and adjust the messages if they are too confusing for users. In any case, it definitely seems like a bug that these messages were not being displayed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been generating these error messages, but we never print them, even though it seems like we probably mean to be printing them.
Fixes #2774
Fixes CLI-170