fix(crons): Don't panic when passing --auth-token#2172
Merged
szokeasaurusrex merged 1 commit intomasterfrom Oct 22, 2024
Merged
fix(crons): Don't panic when passing --auth-token#2172szokeasaurusrex merged 1 commit intomasterfrom
--auth-token#2172szokeasaurusrex merged 1 commit intomasterfrom
Conversation
The `--auth-token` argument is hidden from the `sentry-cli monitors run` subcommand since the command uses DSN authentication, however passing the argument is still possible (it is simply ignored). However, previously providing this argument caused a panic with a not-very-user-friendly message, since the argument was defined here without the auth token parser, and we attempt to read the auth token as an AuthToken. This PR fixes the bug. Fixes #2170
loewenheim
approved these changes
Oct 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--auth-tokenargument is hidden from thesentry-cli monitors runsubcommand since the command uses DSN authentication, however passing the argument is still possible (it is simply ignored).However, providing this argument causes a panic with a not-very-user-friendly message, since the argument was defined here without the auth token parser, and we attempt to read the auth token as an AuthToken.
This PR fixes the bug.
Fixes #2170