Skip to content

fix: Make URL in org auth tokens optional#1766

Merged
loewenheim merged 1 commit intomasterfrom
fix/org-token-optional-url
Oct 2, 2023
Merged

fix: Make URL in org auth tokens optional#1766
loewenheim merged 1 commit intomasterfrom
fix/org-token-optional-url

Conversation

@loewenheim
Copy link
Copy Markdown
Contributor

@loewenheim loewenheim commented Oct 2, 2023

This makes the URL field of org auth tokens optional. Local and self-hosted Sentry instances don't return a URL within their tokens sometimes. In such cases, the URL now needs to be set via one of the other ways (CLI option, env var, config file). It is still an error to pass different URLs via the token and another method.

Fixes #1763, #1765.

@loewenheim loewenheim self-assigned this Oct 2, 2023
@loewenheim loewenheim requested a review from Swatinem October 2, 2023 14:00
@loewenheim loewenheim merged commit 079ccc1 into master Oct 2, 2023
@loewenheim loewenheim deleted the fix/org-token-optional-url branch October 2, 2023 15:01
@lforst
Copy link
Copy Markdown

lforst commented Oct 4, 2023

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry CLI could use --url argument when org auth token has url: null

3 participants