feat(self-hosted): Introduce setting to toggle air-gapped environments#99281
Merged
vgrozdanic merged 1 commit intomasterfrom Sep 11, 2025
Merged
feat(self-hosted): Introduce setting to toggle air-gapped environments#99281vgrozdanic merged 1 commit intomasterfrom
vgrozdanic merged 1 commit intomasterfrom
Conversation
vgrozdanic
commented
Sep 11, 2025
| # Controls whether the async task fetches AI model prices from | ||
| # external sources and stores them in cache. | ||
| register( | ||
| "ai.model-costs.enable-external-price-fetch", |
Member
Author
There was a problem hiding this comment.
we no longer need this, as we will use SENTRY_AIR_GAP instead
aldy505
approved these changes
Sep 11, 2025
Collaborator
aldy505
left a comment
There was a problem hiding this comment.
Is it only that specific endpoint?
Member
Author
for now i think yes, but i will also let others know in our company wide channel once this is merged, to adjust their code if needed |
shellmayr
approved these changes
Sep 11, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99281 +/- ##
==========================================
- Coverage 81.24% 81.24% -0.01%
==========================================
Files 8577 8577
Lines 379247 379247
Branches 24079 24079
==========================================
- Hits 308135 308132 -3
- Misses 70756 70759 +3
Partials 356 356 |
ddce768 to
e765fd5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
e765fd5 to
95cdb36
Compare
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functionalities of Sentry require outbound network calls, which are impossible in air-gapped self hosted environments.
This PR introduces a setting which can be toggled in self-hosted settings file to stop those kind of tasks from executing.