fix(replay): Correct getOutputType to not use non-existant BODY_SKIPPED warning#84654
Merged
fix(replay): Correct getOutputType to not use non-existant BODY_SKIPPED warning#84654
getOutputType to not use non-existant BODY_SKIPPED warning#84654Conversation
…IPPED` warning This actually does not exist in our SDK, instead we can make the same assumption using sdk configuration options (e.g. if they have the option enabled) and if the body is empty to determine if we should show the onboarding setup. ref: getsentry/sentry-javascript#7953 (comment) closes: getsentry/sentry-javascript#8004
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 91.71kB (0.28%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: app-webpack-bundle-array-pushAssets Changed:
|
ryan953
reviewed
Feb 7, 2025
Comment on lines
+729
to
+731
| isNetworkCaptureBodySetup = memoize(() => { | ||
| return Boolean(this.getSDKOptions()?.networkCaptureBodies); | ||
| }); |
Member
There was a problem hiding this comment.
could skip memoize here, but nbd either way
ryan953
reviewed
Feb 7, 2025
Comment on lines
+74
to
+76
| // Capture body is not setup (this should also imply there is no body) | ||
| if (['request', 'response'].includes(visibleTab) && !hasBody && !isCaptureBodySetup) { | ||
| return Output.BODY_SKIPPED; |
ryan953
approved these changes
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This actually does not exist in our SDK, instead we can make the same assumption using sdk configuration options (e.g. if they have the option enabled) and if the body is empty to determine if we should show the onboarding setup.
ref: getsentry/sentry-javascript#7953 (comment)
closes: getsentry/sentry-javascript#8004