feat(performance): Update webvitals module to exclude unparameterized transactions#71923
Merged
edwardgou-sentry merged 3 commits intomasterfrom Jun 4, 2024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71923 +/- ##
==========================================
+ Coverage 77.91% 77.92% +0.01%
==========================================
Files 6563 6567 +4
Lines 292281 292385 +104
Branches 50488 50510 +22
==========================================
+ Hits 227733 227855 +122
+ Misses 58299 58282 -17
+ Partials 6249 6248 -1
|
AbhiPrasad
approved these changes
Jun 4, 2024
Contributor
AbhiPrasad
left a comment
There was a problem hiding this comment.
IMO needs a test to make sure this doesn't regress
Contributor
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors Web Vitals base query as a constant in
DEFAULT_QUERY_FILTERFilters out invalid pageloads and interactions via
!transaction:"<< unparameterized >>"Deletes a couple of query hooks no longer being used.
Fixes #71435