feat(sessions): Remove unused sessions ingestion feature flags#69860
Merged
feat(sessions): Remove unused sessions ingestion feature flags#69860
Conversation
iambriccardo
approved these changes
Apr 29, 2024
jjbayer
approved these changes
Apr 29, 2024
Member
jjbayer
left a comment
There was a problem hiding this comment.
Could you also link getsentry/relay#2050 in the PR description? That's when we stopped forwarding the feature flag to external Relays apparently.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69860 +/- ##
==========================================
- Coverage 79.84% 79.84% -0.01%
==========================================
Files 6486 6486
Lines 288285 288282 -3
Branches 49667 49666 -1
==========================================
- Hits 230185 230175 -10
- Misses 57698 57705 +7
Partials 402 402
|
iker-barriocanal
approved these changes
Apr 29, 2024
Contributor
iker-barriocanal
left a comment
There was a problem hiding this comment.
Are these defined/used in getsentry?
markstory
approved these changes
Apr 29, 2024
Member
Author
See the linked getsentry PR ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relay can no longer ingest sessions into Kafka after getsentry/relay#3271 making these feature flags obsolete.
See also: getsentry/relay#3368 and getsentry/relay#3492