feat(js-loader): Only use es5/es6 bundles in v7 JS loader#66303
Merged
feat(js-loader): Only use es5/es6 bundles in v7 JS loader#66303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66303 +/- ##
========================================
Coverage 84.29% 84.29%
========================================
Files 5306 5309 +3
Lines 237041 237228 +187
Branches 41020 41039 +19
========================================
+ Hits 199805 199982 +177
- Misses 37017 37027 +10
Partials 219 219
|
lforst
reviewed
Mar 5, 2024
Contributor
lforst
left a comment
There was a problem hiding this comment.
It would be great to add some tests to the existing loader tests for this change.
We can probably copy & paste the implementation from here:
sentry/tests/sentry/web/frontend/test_js_sdk_loader.py
Lines 85 to 100 in 6cb54b1
| "hasDebug": False, | ||
| } | ||
|
|
||
| is_greater_or_equal_v7_sdk = sdk_version >= Version("7.0.0") |
Contributor
There was a problem hiding this comment.
I think we can leave the name of is_greater_or_equal_v7_sdk as-is. Imo it doesn't add any value renaming and that way git blame is a bit more useful.
lforst
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the coming version of the JS SDK only uses ES2017 bundles, it is no longer necessary to differentiate between es5 and es6 bundles.
ref getsentry/sentry-javascript#10911