Skip to content

Renamed 'account number' to correct name 'Account ID'#58320

Merged
antonpirker merged 1 commit intomasterfrom
antonpirker/aws-lambda-account-id
Oct 24, 2023
Merged

Renamed 'account number' to correct name 'Account ID'#58320
antonpirker merged 1 commit intomasterfrom
antonpirker/aws-lambda-account-id

Conversation

@antonpirker
Copy link
Contributor

In AWS it is called Account ID and not Account number.
Renamed all visible occurrences in AWS Lambda integration.

Screenshot 2023-10-18 at 11 38 59

@antonpirker antonpirker requested a review from a team as a code owner October 18, 2023 09:41
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 18, 2023
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #58320 (de699cd) into master (3b1fc12) will increase coverage by 0.00%.
Report is 69 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #58320    +/-   ##
========================================
  Coverage   79.06%   79.06%            
========================================
  Files        5138     5140     +2     
  Lines      223568   223845   +277     
  Branches    37641    37698    +57     
========================================
+ Hits       176767   176987   +220     
- Misses      41143    41185    +42     
- Partials     5658     5673    +15     
Files Coverage Δ
src/sentry/integrations/aws_lambda/client.py 94.18% <ø> (ø)
static/app/utils/profiling/frame.tsx 81.81% <ø> (ø)
...atic/app/utils/profiling/profile/importProfile.tsx 84.61% <ø> (-0.20%) ⬇️
static/app/utils/profiling/profile/utils.tsx 52.56% <ø> (-0.61%) ⬇️
...ws/integrationPipeline/awsLambdaCloudformation.tsx 71.64% <ø> (+2.07%) ⬆️

... and 52 files with indirect coverage changes

Copy link
Contributor

@17hogeju 17hogeju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antonpirker antonpirker merged commit f48992b into master Oct 24, 2023
@antonpirker antonpirker deleted the antonpirker/aws-lambda-account-id branch October 24, 2023 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants