feat(inbound-filters) Add health check inbound filter#49176
Merged
Conversation
jjbayer
approved these changes
May 16, 2023
Member
jjbayer
left a comment
There was a problem hiding this comment.
Looks good to me! See comments about tests, especially the one about validate_project_config.
Comment on lines
+409
to
+431
| @pytest.mark.django_db | ||
| @pytest.mark.parametrize("is_business", [True, False], ids=["business_plan", "free_plan"]) | ||
| def test_health_check_filters(call_endpoint, add_org_key, relay, default_project, is_business): | ||
| """ | ||
| Test that only business plans contain healthcheck filters | ||
| """ | ||
| relay.save() | ||
|
|
||
| default_project.update_option("filters:health-check", "1") | ||
| with Feature({"organizations:health-check-filter": is_business}): | ||
| result, status_code = call_endpoint(full_config=True, version=2) | ||
|
|
||
| assert status_code < 400 | ||
|
|
||
| configs = safe.get_path(result, "configs") | ||
|
|
||
| (project_key,) = configs.keys() | ||
| filter_settings = safe.get_path(configs, project_key, "config", "filterSettings") | ||
| assert filter_settings is not None | ||
|
|
||
| has_health_check = "healthCheck" in filter_settings | ||
|
|
||
| assert has_health_check == is_business |
Member
There was a problem hiding this comment.
- This test could be moved to test_config.py, i.e. test
get_project_configdirectly instead of testing the endpoint. - Please call
validate_project_configin one of the tests to make sure that relay can parse the new config.
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
priscilawebdev
approved these changes
May 17, 2023
Member
priscilawebdev
left a comment
There was a problem hiding this comment.
the code looks good to me
| # the number of events filtered because their group was discarded | ||
| project_total_received_discarded = 610 | ||
| # the number of events filtered because they refer to a healthcheck endpoint | ||
| project_total_healthcheck = 611 |
Member
There was a problem hiding this comment.
do we need this? Jan told me once that this is something really old and not very used
Member
There was a problem hiding this comment.
just saw that it is being used. so never mind
|
|
||
| if filter_id in ("browser-extensions", "localhost", "web-crawlers"): | ||
| if filter_id in ( | ||
| FilterStatKeys.BROWSER_EXTENSION, |
iambriccardo
approved these changes
May 19, 2023
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #49176 +/- ##
=========================================
- Coverage 81.30 79.60 -1.70
=========================================
Files 4897 4897
Lines 205567 205584 +17
Branches 11051 11051
=========================================
- Hits 167121 163654 -3467
- Misses 38201 41685 +3484
Partials 245 245
|
1a3095f to
b65707f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for inbound filters for health check transactions.
implements: #49081