fix(webhooks): Reset some tags and context for JIRA & GHE#45368
Merged
fix(webhooks): Reset some tags and context for JIRA & GHE#45368
Conversation
This is a follow up to #45139 for JIRA and Github enterprise. It seems that we're tagging events with information about organizations even when it's impossible to have any org info. We have events tagged with the following info even when it is not possible: - org slug - org id - org context This issues causes finding errors that are for the wrong organization when using `organization.slug`, thus, wasting time for engineers and customer support. This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue. Here's a [query](https://sentry.sentry.io/discover/results/?end=2023-03-04T04%3A59%3A59&field=transaction&field=count_unique%28organization.slug%29&field=count%28%29&name=Integration.DoesNotExist%3A+Integration+matching+query+does+not+exist.&project=1&query=%21organization.slug%3A%22%22+error.value%3A%22Integration+matching+query+does+not+exist.%22&sort=-transaction&start=2023-03-02T05%3A00%3A00&yAxis=count%28%29) showing transactions that should not have org values set. Fix [WOR-2464](https://getsentry.atlassian.net/browse/WOR-2464)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45368 +/- ##
==========================================
- Coverage 80.22% 79.75% -0.47%
==========================================
Files 4724 4725 +1
Lines 198815 198822 +7
Branches 12006 12006
==========================================
- Hits 159506 158580 -926
- Misses 39047 39980 +933
Partials 262 262
|
scttcper
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #45139 for JIRA and Github enterprise.
It seems that we're tagging events with information about organizations even when it's impossible to have any org info.
We have events tagged with the following info even when it is not possible:
This issues causes finding errors that are for the wrong organization when using
organization.slug, thus, wasting time for engineers and customer support.This change only clears the invalid tag values to reduce the impact of this issue rather than fixing the root issue.
Here's a query showing transactions that should not have org values set.
Fixes WOR-2464