test(metric-extraction): Skip test_all_transaction_metrics_emitted test and add new metric c:transactions@count_per_root_project [TET-627]#43167
Merged
andriisoldatenko merged 2 commits intomasterfrom Jan 12, 2023
Conversation
MetricsExtractionTest.test_all_transaction_metrics_emitted test until Relay pr will be merged
MetricsExtractionTest.test_all_transaction_metrics_emitted test until Relay pr will be mergedMetricsExtractionTest.test_all_transaction_metrics_emitted test until Relay pr will be merged [TET-627]
3 tasks
…traction.MetricsExtractionTest.test_all_transaction_metrics_emitted test until Relay pr will be merged
a5e3e66 to
b7ddc23
Compare
jjbayer
approved these changes
Jan 12, 2023
iambriccardo
approved these changes
Jan 12, 2023
jjbayer
approved these changes
Jan 12, 2023
Member
jjbayer
left a comment
There was a problem hiding this comment.
Please update the PR title + description to reflect that this PR now actually adds a new entry to the indexer's static strings, which changes production behavior rather than just tests.
| "d:transactions/breakdowns.span_ops.ops.browser@millisecond": PREFIX + 122, | ||
| "d:transactions/breakdowns.span_ops.ops.resource@millisecond": PREFIX + 123, | ||
| "d:transactions/breakdowns.span_ops.ops.ui@millisecond": PREFIX + 124, | ||
| "c:transactions/count_per_root_project@none": PREFIX + 125, |
Member
There was a problem hiding this comment.
For reference: When adding strings here, we must make sure that they don't already exist in the db. This is improbable for new MRIs, but better safe than sorry.
sentry/src/sentry/sentry_metrics/indexer/strings.py
Lines 18 to 19 in 9a0ae70
select * from sentry_perfstringindexer where string = 'c:transactions/count_per_root_project@none';
select * from sentry_stringindexer where string = 'c:transactions/count_per_root_project@none';Both queries yield 0 results, so it seems we are good.
Contributor
Author
There was a problem hiding this comment.
@jjbayer good catch! PR title has been updated.
MetricsExtractionTest.test_all_transaction_metrics_emitted test until Relay pr will be merged [TET-627]test_all_transaction_metrics_emitted test until Relay pr will be merged and add new metric c:transactions@count_per_root_project` [TET-627]
test_all_transaction_metrics_emitted test until Relay pr will be merged and add new metric c:transactions@count_per_root_project` [TET-627]test_all_transaction_metrics_emitted test and add new metric c:transactions@count_per_root_project [TET-627]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips the test
tests.relay_integration.test_metrics_extraction.MetricsExtractionTest.test_all_transaction_metrics_emitted,Also adds new metric
c:transactions@count_per_root_projecttoTRANSACTION_METRICS_NAMES.I'll remove
@skiptag right after Relay PR with new metric will be merged.