feat: Support latest identifier on checkins#42819
Merged
Conversation
dcramer
commented
Jan 5, 2023
src/sentry/api/base.py
Outdated
Member
Author
There was a problem hiding this comment.
request is always present here so no need to use our internal abstraction
f3d6f3b to
66265e3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
dcramer
commented
Jan 5, 2023
66265e3 to
1bbbdc2
Compare
1bbbdc2 to
7956d93
Compare
Add the ability to target `latest` as the `checkin_id` parameter, which will pull the most recent (creation date) check-in that is not yet marked as finished. Fixes GH-42816
7956d93 to
e7858e0
Compare
davidenwang
approved these changes
Jan 5, 2023
Contributor
davidenwang
left a comment
There was a problem hiding this comment.
new monitors code looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to target
latestas thecheckin_idparameter, which will pull the most recent (creation date) check-in that is not yet marked as finished.Fixes GH-42816