Skip to content

ref(hybrid-cloud): use organization_slug in MonitorCheckIns#42356

Merged
cathteng merged 3 commits intomasterfrom
cathyteng17/hc/convert-orgless-monitor-checkins-api
Dec 14, 2022
Merged

ref(hybrid-cloud): use organization_slug in MonitorCheckIns#42356
cathteng merged 3 commits intomasterfrom
cathyteng17/hc/convert-orgless-monitor-checkins-api

Conversation

@cathteng
Copy link
Copy Markdown
Contributor

@cathteng cathteng commented Dec 14, 2022

Adds organization_slug to the url for the MonitorCheckIns endpoint. Keeps the original orgless URL for now.

Also refactors MonitorEndpoint and MonitorTestCase for better reusability.

For HC-513

@cathteng cathteng requested review from a team and RyanSkonnord December 14, 2022 21:45
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 14, 2022
@cathteng cathteng changed the title chore(hybrid-cloud): use organization_slug in MonitorCheckIns ref(hybrid-cloud): use organization_slug in MonitorCheckIns Dec 14, 2022
@cathteng cathteng marked this pull request as ready for review December 14, 2022 22:09
@cathteng cathteng requested a review from a team as a code owner December 14, 2022 22:09
Copy link
Copy Markdown
Contributor

@RyanSkonnord RyanSkonnord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cathteng cathteng merged commit 7cfdb82 into master Dec 14, 2022
@cathteng cathteng deleted the cathyteng17/hc/convert-orgless-monitor-checkins-api branch December 14, 2022 22:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants