Merged
Conversation
| all_errors.append({ | ||
| 'type': EventError.JS_MISSING_SOURCE, | ||
| 'url': force_bytes(abs_path, errors='replace'), | ||
| 'url': expose_url(abs_path), |
Contributor
There was a problem hiding this comment.
Seems only a matter of time that someone will create an error without using expose_url ... what if we funneled through a helper function?
Contributor
There was a problem hiding this comment.
i.e. can this be done in EventError?
Contributor
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
| if url is None: | ||
| return u'<unknown>' | ||
| if url.startswith('data:'): | ||
| return u'<data url>' |
Member
There was a problem hiding this comment.
maybe data:<redacted> would be better?
minor, and i dont care that much (esp since its merged already)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@getsentry/infrastructure
This change is