Skip to content

Add simulator to device info#3723

Closed
mitsuhiko wants to merge 4 commits intomasterfrom
feature/sim-in-tag
Closed

Add simulator to device info#3723
mitsuhiko wants to merge 4 commits intomasterfrom
feature/sim-in-tag

Conversation

@mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Jul 14, 2016

This change is Reviewable

@dcramer
Copy link
Member

dcramer commented Jul 14, 2016

One thought, would it be better to do X (Simulator) rather than just X Simulator


Reviewed 3 of 3 files at r1.
Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@mitsuhiko
Copy link
Contributor Author

@dcramer the device family reported by ios is "iPhone Simulator" and not "iPhone (Simulator)" so I figured we should try to match it.


Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@mitsuhiko
Copy link
Contributor Author

That said, i have no idea if that makes sense for Android :)


Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@dcramer
Copy link
Member

dcramer commented Aug 19, 2016

I'm still +1on getting this change in

@dcramer
Copy link
Member

dcramer commented Aug 19, 2016

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@mitsuhiko
Copy link
Contributor Author

I'm going to revisit this PR now. I'm still not super happy with some of the effects it has.

@markstory
Copy link
Member

Is this something we're still interested in pursuing or can it be closed?

@markstory markstory closed this Sep 4, 2018
@markstory markstory deleted the feature/sim-in-tag branch September 21, 2018 02:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants