Conversation
…me is not RFC 1034/1035 compliant
JoshFerge
reviewed
Jul 27, 2022
|
|
||
| host = request.get_host().lower() | ||
| try: | ||
| host = request.get_host().lower() |
Member
There was a problem hiding this comment.
should you still lowercase it if get_host fails?
Member
Author
There was a problem hiding this comment.
@JoshFerge If an exception is raised in get_host(), I expect the chained lower() method to not be called at all.
I'm unsure if I understood what you meant by here.
Member
There was a problem hiding this comment.
ah needed to expand logic below to see how host was being used, that makes sense 👍🏼
markstory
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpRequest.get_host()will raisedjango.core.exceptions.DisallowedHostif theHTTP_HOSTheader does not comply with RFC 1034/1035. In this case, we just bail out of the subdomain middleware early and continue processing the request.Fixes SENTRY-VJD and others.