Conversation
In getsentry/relay#1225 we introduced a general-purpose tagging system for transaction metrics. This may later be extended: * we will add outlier tagging for histograms soon * session metrics could be tagged the same way (unlikely to happen for now, needs changes in Relay) Here we move away from the purpose-built user satisfaction impl to the more generic one
jjbayer
left a comment
There was a problem hiding this comment.
Some minor remarks, otherwise LGTM!
Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
| "inner": [ | ||
| { | ||
| "op": "gt", | ||
| "name": _TRANSACTION_METRICS_TO_RULE_FIELD[threshold.metric], |
There was a problem hiding this comment.
fwiw this was ported from this piece of relay code: https://github.com/getsentry/relay/blob/043479fe570949003964c672ed3dda7253a98292/relay-server/src/metrics_extraction/transactions.rs#L118-L132=
|
@jjbayer making you re-review this since I added histogram outliers |
| "inner": [ | ||
| {"op": "eq", "name": "event.contexts.trace.op", "value": op}, | ||
| {"op": "eq", "name": "event.platform", "value": platform}, | ||
| {"op": "gte", "name": "event.duration", "value": p25 + 3 * p75}, |
There was a problem hiding this comment.
Could we add a comment here on why we use p25 + 3 * p75? I tried googling Tukey's fences but the only formula I found was p75 + 3 * (p75 - p25).
There was a problem hiding this comment.
oof you're right, the calculation is completely messed up. copied it from a document that is apparently wrong
| "condition": { | ||
| "op": "and", | ||
| "inner": [ | ||
| {"op": "gte", "name": "event.duration", "value": 0}, |
There was a problem hiding this comment.
Does this mean that any (platform, op) combination that is not among the Top-50 gets tagged as 100% outliers?
There was a problem hiding this comment.
yup this was also wrong. now changed to inlier
…onal-tagging-transaction-thresholds
In getsentry/relay#1225 we introduced a
general-purpose tagging system for transaction metrics. This may later
be extended:
Here we move away from the purpose-built user satisfaction impl to the
more generic one