Skip to content

test: get eslintPluginScraps tests running, and fixed use-semantic-token's#109326

Merged
JoshuaKGoldberg merged 1 commit into
masterfrom
eslint-plugin-scraps-testing-enable
Feb 26, 2026
Merged

test: get eslintPluginScraps tests running, and fixed use-semantic-token's#109326
JoshuaKGoldberg merged 1 commit into
masterfrom
eslint-plugin-scraps-testing-enable

Conversation

@JoshuaKGoldberg

@JoshuaKGoldberg JoshuaKGoldberg commented Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Similar to #109310, changes the test extensions from *.spec.mjs to *.spec.js. The m is unnecessary because Jest is configured to treat their syntax as ESM either way.

static/eslint/eslintPluginScraps/src/rules/use-semantic-token.spec.js had some failures in the helper-function-generated invalid cases:

  • Most were using the invalidProperty message ID instead of invalidPropertyWithSuggestion, and missing data.suggestedCategory
  • A few were actually not invalid at all and had zero errors

Fixes https://linear.app/getsentry/issue/ENG-6931/get-eslintpluginscraps-tests-running

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 25, 2026
Merged
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 25, 2026
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 25, 2026 16:44
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team as a code owner February 25, 2026 16:44
JoshuaKGoldberg
JoshuaKGoldberg commented Feb 25, 2026
View reviewed changes
Comment thread static/eslint/eslintPluginScraps/src/rules/use-semantic-token.spec.js

@JoshuaKGoldberg JoshuaKGoldberg Feb 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Question] I removed invalid* object entries that didn't produce any lint rule reports. Was that correct? Should this change move them to valid, or...?

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 25, 2026
Merged
natemoo-re
natemoo-re approved these changes Feb 25, 2026
View reviewed changes

@natemoo-re natemoo-re left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 32fc066 into master Feb 26, 2026
64 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-plugin-scraps-testing-enable branch February 26, 2026 16:59
@linear

linear Bot commented Mar 2, 2026

Copy link
Copy Markdown

ENG-6931 Get eslintPluginScraps tests running

@github-actions github-actions Bot locked and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes
+1 more reviewer
@JonasBa JonasBa JonasBa approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JoshuaKGoldberg @natemoo-re @JonasBa