feat(dashboards): Convert Widget Builder dataset selector to a dropdown #105928
+122
−80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static/app/views/dashboards/widgetBuilder/components/datasetSelector.spec.tsx
Outdated
Show resolved
Hide resolved
Update test selectors to use proper CompactSelect accessibility patterns: - Click button by role with current selection instead of label text - Find options using proper role selectors - Check disabled state with aria-disabled attribute
- Update dataset change test to click CompactSelect button then option - Make popper-related tests async to wait for state updates - Add waitFor to flush pending popper updates before test completion
Update test to open CompactSelect dropdown and verify options using proper accessibility roles instead of checking for radiogroup.
- Errors: Errors from your application - Spans: Spans from distributed traces - Logs: Structured application logs - Issues: Grouped events from the Issues Feed - Releases: Session data from releases - Metrics: Counters, guages, and distributions - Transactions: No longer supported. Use the spans dataset.
static/app/views/dashboards/widgetBuilder/components/datasetSelector.tsx
Show resolved
Hide resolved
static/app/views/dashboards/widgetBuilder/components/datasetSelector.tsx
Outdated
Show resolved
Hide resolved
1. Remove disabled attribute from transactions option to allow clicking
the migration link when transactions are deprecated
2. Prevent selection programmatically in onChange handler instead
3. Show proper description for transactions when not deprecated
("Transactions from your application" instead of deprecation message)
Fixes issues identified in PR review:
- Disabled option prevented clicking the spans migration link
- Transactions showed deprecation message even when supported
…ilder-dataset-radios-to-compactselect
This will prevent bad overflow when on mobile
narsaynorath
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are slightly too many options there now, and we're actually adding a new one soon, so it's a bit outta control. Instead of a bunch of radio options, let's use a dropdown.
Before:
After:
