feat(dynamic-groups): Add progress bar to aggregate tags #105878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a progress bar style indicator and moves the tooltip with more details to the progress bar.
cvxluo
approved these changes
Jan 8, 2026
| const totalCount = tag.totalValues; | ||
| const topValuePct = | ||
| topValue && totalCount > 0 ? Math.round((topValue.count / totalCount) * 100) : null; | ||
| const barValues = tag.topValues.slice(0, 4); |
Contributor
There was a problem hiding this comment.
Bar shows 4 segments but tooltip explains only 3
Low Severity
The new inline progress bar displays up to 4 value segments via barValues = tag.topValues.slice(0, 4), but the TagDistributionPreview tooltip still uses slice(0, 3) to show only 3 values. When users hover over the bar, the 4th colored segment won't have a corresponding entry in the tooltip legend, creating a confusing visual mismatch between what the bar displays and what the tooltip explains.
Additional Locations (1)
JonasBa
reviewed
Jan 8, 2026
| border-radius: 3px; | ||
| overflow: hidden; | ||
| background: ${p => p.theme.backgroundSecondary}; | ||
| box-shadow: inset 0 0 0 1px ${p => p.theme.translucentBorder}; |
Member
There was a problem hiding this comment.
With the exception of this one, I think they could all be either a flex or a container component. Whats the use case for the inset shadow here? Avoiding an external border?
Member
Author
There was a problem hiding this comment.
going to delete them, i promise
# Conflicts: # static/app/views/issueList/pages/topIssues.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a progress bar style indicator and moves the tooltip with more details to the progress bar.