feat(Issues): AI Search #105768
feat(Issues): AI Search #105768
Conversation
| pageFilters.selection.projects?.length > 0 && | ||
| pageFilters.selection.projects?.[0] !== -1 | ||
| ? pageFilters.selection.projects | ||
| : projects.filter(p => p.isMember).map(p => p.id); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| const endLocal = resultEnd.endsWith('Z') ? resultEnd.slice(0, -1) : resultEnd; | ||
| timeParams = { | ||
| start: new Date(startLocal).toISOString(), | ||
| end: new Date(endLocal).toISOString(), |
There was a problem hiding this comment.
Missing validation for invalid date strings causes crash
Medium Severity
The applySeerSearchQuery callback calls new Date(startLocal).toISOString() without validating that the date strings from the AI-powered API response are valid dates. If the API returns a malformed date string (possible with AI responses), new Date("invalid-string") creates an Invalid Date object, and calling .toISOString() on it throws an uncaught RangeError: Invalid time value. This would crash the component when a user selects a query result.
There was a problem hiding this comment.
interesting point, we do validate this on the backend, but curious if we should also validate here.
| <SearchQueryBuilderProvider | ||
| initialQuery={query || ''} | ||
| filterKeys={getFilterKeys()} |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nsdeschenes
left a comment
There was a problem hiding this comment.
Couple of comments, small things non-blocking
| let initialSeerQuery = ''; | ||
| const queryDetails = useMemo(() => { | ||
| const queryToUse = committedQuery.length > 0 ? committedQuery : query; | ||
| const parsedQuery = parseQueryBuilderValue(queryToUse, getFieldDefinition); |
There was a problem hiding this comment.
Comment about this from the errors PR also applicable here 👀
| navigate({ | ||
| pathname: location.pathname, | ||
| query: queryParams, | ||
| }); |
There was a problem hiding this comment.
Do we need the same options passed here, like prevent scroll etc.?
4817ea5 to
f589d73
Compare
gen-ai-search-agent-translatefor internal use first