-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(dashboards): support http spans in details component #105545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DominikB2014
merged 4 commits into
master
from
dominikbuszowiecki/browse-209-update-details-widget-to-support-http-spans
Dec 31, 2025
Merged
feat(dashboards): support http spans in details component #105545
DominikB2014
merged 4 commits into
master
from
dominikbuszowiecki/browse-209-update-details-widget-to-support-http-spans
Dec 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DominikB2014
commented
Dec 30, 2025
- If an http span is detected in the details component, it now renders out the domain preview
- The details widget now support a height of 1, this makes it much cleaner with http spans.
|
|
||
| const DOMAIN_WIDGET: Widget = { | ||
| id: 'domain-widget', | ||
| title: t('Domain'), |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query is provided by the global filter
static/app/views/dashboards/widgets/detailsWidget/detailsWidgetVisualization.tsx
Outdated
Show resolved
Hide resolved
DominikB2014
commented
Dec 31, 2025
static/app/views/dashboards/widgets/detailsWidget/detailsWidgetVisualization.tsx
Outdated
Show resolved
Hide resolved
static/app/views/dashboards/widgets/detailsWidget/detailsWidgetVisualization.tsx
Show resolved
Hide resolved
edwardgou-sentry
approved these changes
Dec 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.