feat(issues): Protect GroupResolutions from release cleanup #105444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #104751 When a release is deleted but has GroupResolutions pointing to it, the resolution tracking data is lost. This causes false positive regressions when new events arrive from older releases - GroupResolution.has_resolution() can no longer determine that the issue was already resolved. Now we check for ALL GroupResolutions (not just within 90 days) when determining if a release can be cleaned up.
yuvmen
approved these changes
Dec 23, 2025
Member
yuvmen
left a comment
There was a problem hiding this comment.
I think this makes sense. We will basically always be keeping releases that ever had issues resolved on them, but maybe thats ok. Lets do this and see what release cleanup looks like down the line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104751
When a release is deleted but has GroupResolutions pointing to it, the resolution tracking data is lost. This causes false positive regressions when new events arrive from older releases - GroupResolution.has_resolution() can no longer determine that the issue was already resolved.
Now we check for ALL GroupResolutions (not just within 90 days) when determining if a release can be cleaned up.