feat(autopilot): SDK update detector logging #105384
Conversation
|
|
||
| updates_list = [update for update in updates_list if len(update["suggestions"]) > 0] | ||
|
|
||
| logger.warning("updates_list: %s", updates_list) |
There was a problem hiding this comment.
Debug logging using WARNING level in production task
The logger.warning("updates_list: %s", updates_list) statement logs the entire updates list at WARNING level. This appears to be debug/diagnostic code that is inappropriate for production. WARNING level logs are typically monitored and may trigger alerts. Since this task runs every 5 minutes for all allowlisted organizations, this will generate significant log volume with potentially large data structures containing SDK names, versions, and project IDs. Consider using logger.debug or logger.info instead, or removing it if the metrics call on the next line provides sufficient observability.
There was a problem hiding this comment.
info logs are filtered out. for version, we want it to be visible
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105384 +/- ##
===========================================
+ Coverage 80.24% 80.57% +0.33%
===========================================
Files 9433 9440 +7
Lines 404618 404711 +93
Branches 25680 25680
===========================================
+ Hits 324668 326087 +1419
+ Misses 79481 78155 -1326
Partials 469 469 |
| sorted(sdks_used, key=lambda x: x["sdk.name"]), key=lambda x: x["sdk.name"] | ||
| ) | ||
| ] | ||
| for project_id, sdks_used in groupby(nonempty_sdks, key=lambda x: x["project.id"]) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Add first POC of a detector for Autopilot, that detects outdated SDKs.
This version simply emits metrics for checking the system's behavior.