Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff            @@
##           master   #105323    +/-   ##
=========================================
  Coverage   80.58%    80.58%            
=========================================
  Files        9438      9437     -1     
  Lines      404466    404596   +130     
  Branches    25698     25698            
=========================================
+ Hits       325941    326047   +106     
- Misses      78057     78081    +24     
  Partials      468       468            

Looks good to me, what happens if base_artifact or base_metric are null will the evidence table just remove them?

In this particular bit of code I think we should always have base_artifact (& base_metric). In general I think

• evidence_data isn't actually displayed anywhere by default
• evidence_display is displayed as a table (if the issue type opts into it by making a change in that file that was in the last review)
• evidence_display being null I think is not an issue since you have to make an IssueEvidence object and that enforces the key and value are both strings.