feat(explore-attr-breakdowns): Selection CTA should be dismissed upon first box draw #105249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abdkhan14
commented
Dec 18, 2025
… first chart selection
| if (!isChartSelectionAlertDismissed) { | ||
| dismissChartSelectionAlert(); | ||
| } | ||
| }, |
Contributor
There was a problem hiding this comment.
Bug: Alert not immediately dismissed due to separate hook instances
The useDismissAlert hook is used in two separate components with the same key, but each instance maintains its own React state. When dismissChartSelectionAlert() is called in the Chart component, it updates localStorage but the ChartSelectionAlert component's state remains unchanged because useLocalStorageState doesn't sync state across instances. The alert will persist until the component remounts (on navigation or refresh), not immediately upon box draw as intended by the PR.
Additional Locations (1)
Contributor
Author
There was a problem hiding this comment.
Desired behaviour, only shouldn't exist on next load.
nsdeschenes
approved these changes
Dec 18, 2025
9e81308
into
abdk/explore-attr-breakdowns-menu-vis
43 of 45 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.