feat(eap): Expose trace attachments in details endpoint #105223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #105223 +/- ##
============================================
+ Coverage 69.39% 80.63% +11.24%
============================================
Files 9430 9431 +1
Lines 404312 403955 -357
Branches 25656 25603 -53
============================================
+ Hits 280577 325746 +45169
+ Misses 122734 77741 -44993
+ Partials 1001 468 -533 |
| SupportedTraceItemType.TRACEMETRICS: TraceItemType.TRACE_ITEM_TYPE_METRIC, | ||
| SupportedTraceItemType.PROFILE_FUNCTIONS: TraceItemType.TRACE_ITEM_TYPE_PROFILE_FUNCTION, | ||
| SupportedTraceItemType.PREPROD: TraceItemType.TRACE_ITEM_TYPE_PREPROD, | ||
| SupportedTraceItemType.ATTACHMENTS: TraceItemType.TRACE_ITEM_TYPE_ATTACHMENT, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tobias-wilfert
approved these changes
Dec 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make trace attachments queryable via the
/trace-items/<item-id>endpoint.Closes INGEST-696.