feat(explorer): include selected project slugs on on page context #105095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (slug) { | ||
| projectSlugs.push(slug); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Bug: Sentinel value for "All Projects" selection not handled
When users select "All Projects", selection.projects contains [-1] (the ALL_ACCESS_PROJECTS sentinel value). The code enters the block because selection.projects.length > 0 is true, but the Map lookup for -1 returns undefined since no actual project has that ID. This results in an empty projectSlugs array, so no project information is added to the snapshot—even though the project selector is visible and the user has meaningfully selected "All Projects". Other parts of the codebase explicitly check for this -1 sentinel value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes AIML-2107