feat(preprod): Set platform on size issues #105039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| occurrence, event_data = diff_to_occurrence(project_id, "download", diff) | ||
| occurrence, event_data = diff_to_occurrence( | ||
| project_id, "download", diff, head_metric.preprod_artifact.artifact_type | ||
| ) |
Contributor
There was a problem hiding this comment.
Bug: Nullable artifact_type may cause ValueError exception
The artifact_type field on PreprodArtifact is nullable (defined with null=True in the model), but platform_from_artifact_type raises ValueError when given None or an unknown type. Other parts of the codebase check artifact_type is not None before calling this function. If artifact_type is unexpectedly None, the exception will be caught silently and the issue won't be emitted. The previous hardcoded "other" platform value wouldn't have had this failure mode.
Additional Locations (1)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #105039 +/- ##
========================================
Coverage 80.58% 80.58%
========================================
Files 9405 9405
Lines 403218 403221 +3
Branches 25630 25630
========================================
+ Hits 324948 324953 +5
+ Misses 77821 77819 -2
Partials 449 449 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.