feat(agents): Preserve icon on spans with error #104937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #104937 +/- ##
===========================================
- Coverage 80.52% 80.41% -0.12%
===========================================
Files 9398 9393 -5
Lines 405708 403384 -2324
Branches 25923 25923
===========================================
- Hits 326710 324383 -2327
- Misses 78558 78561 +3
Partials 440 440 |
constantinius
approved these changes
Dec 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the AI trace we substitute the span icon with an error icon whenever there is an error on the span status or an issue connected to it. This confused users as they were not sure anymore what type of span they see.
Solution
Preserve the original icon and show the error icon additionally.
Also include a tooltip to explain the meaning of the flame / error icon.
Screen.Recording.2025-12-15.at.08.31.29.mov