feat(agents): Render markdown and allow switching to raw values #104850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Bug: Missing key props cause inconsistent state reset behavior
The PR adds key={getNodeId(node)} to MultilineText and MessagesArrayRenderer components to reset internal state when switching nodes (lines 239, 245), but the MultilineJSON for toolArgs and MultilineText for embeddingsInput don't have this key prop. Since these components now have internal showRaw and clipped state that should reset when nodes change, the missing keys cause inconsistent behavior where some views reset when switching nodes but these don't, potentially showing stale raw/formatted toggle states from a previously viewed node.
static/app/views/performance/newTraceDetails/traceDrawer/details/span/eapSections/aiInput.tsx#L249-L256
…-render-markdown-nicely-in-span-details
static/app/views/performance/newTraceDetails/traceDrawer/details/styles.tsx
Show resolved
Hide resolved
obostjancic
approved these changes
Dec 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render messages as markdown.
Allow switching to raw values for text and json messages.
Adjust the collapsing mechanism to also work with rich content.
Screen.Recording.2025-12-12.at.12.56.43.mov
Screen.Recording.2025-12-12.at.12.47.16.mov