Skip to content

feat(autofix): Add backend check to disable autofix if repos are not connected [feature flagged] #104790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mihir-Mavalankar merged 6 commits into from
Dec 12, 2025
Merged

feat(autofix): Add backend check to disable autofix if repos are not connected [feature flagged] #104790

Mihir-Mavalankar merged 6 commits into from
Dec 12, 2025

Conversation

@Mihir-Mavalankar
Copy link
Contributor

@Mihir-Mavalankar Mihir-Mavalankar commented Dec 11, 2025 •
edited
Loading

PR Details

  • Adds new seer_repos_linked boolean field to the /issues/{group_id}/autofix/setup/ endpoint response
  • When seat-based Seer tier is enabled, checks if repos are linked via get_project_seer_preferences. Returns false when no repos are linked, true otherwise. Defaults to False to enforce check if we fail the call.
  • Frontend can use this to disable the "Start Root Cause Analysis" button when repos aren't configured. Will make a PR for that next.
  • If the github integration itself doesn't exist then we don't even check for linked repos.

@Mihir-Mavalankar Mihir-Mavalankar self-assigned this Dec 11, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 11, 2025
@codecov
Copy link

codecov bot commented Dec 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #104790    +/-   ##
=========================================
  Coverage   80.47%    80.48%            
=========================================
  Files        9363      9369     +6     
  Lines      401849    402418   +569     
  Branches    25833     25833            
=========================================
+ Hits       323389    323887   +498     
- Misses      78018     78089    +71     
  Partials      442       442

@Mihir-Mavalankar Mihir-Mavalankar marked this pull request as ready for review December 11, 2025 22:07
@Mihir-Mavalankar Mihir-Mavalankar requested a review from a team as a code owner December 11, 2025 22:07
JoshFerge
JoshFerge reviewed Dec 11, 2025
View reviewed changes
Zylphrex
Zylphrex reviewed Dec 11, 2025
View reviewed changes
src/sentry/seer/endpoints/group_autofix_setup_check.py Outdated
"project_id": group.project.id,
},
)
seer_repos_linked = True
Copy link
Member

@Zylphrex Zylphrex Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we assume it's True here? Is it errored, shouldn't we be cautious and assume its not linked?

Copy link
Contributor Author

@Mihir-Mavalankar Mihir-Mavalankar Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still run autofix runs if it's not linked. The RCA is just lower quality without code. This what we do today.
Setting it to True is sort of a revert to the original behaviour and definitely won't break anything.

Copy link
Contributor Author

@Mihir-Mavalankar Mihir-Mavalankar Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though to have consistent behaviour with the new paradigm maybe we should just have it as False or show an error?

sentry[bot]
sentry bot reviewed Dec 12, 2025
View reviewed changes
@Mihir-Mavalankar Mihir-Mavalankar enabled auto-merge (squash) December 12, 2025 17:51
@Mihir-Mavalankar Mihir-Mavalankar merged commit 37d1d85 into master Dec 12, 2025
68 checks passed
@Mihir-Mavalankar Mihir-Mavalankar deleted the disbale-autofix-ui-repos-not-connected branch December 12, 2025 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshFerge JoshFerge JoshFerge left review comments

@sentry sentry[bot] sentry[bot] left review comments

@Zylphrex Zylphrex Zylphrex approved these changes

Assignees

@Mihir-Mavalankar Mihir-Mavalankar

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mihir-Mavalankar @JoshFerge @Zylphrex