feat(dashboards): Add loading skeleton for Widget Builder #104702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setError={setError} | ||
| onClose={onCloseWithModal} | ||
| /> | ||
| <VerySlowComponent /> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
static/app/views/dashboards/widgetBuilder/components/widgetBuilderSlideout.tsx
Show resolved
Hide resolved
static/app/views/dashboards/widgetBuilder/components/widgetBuilderSlideout.tsx
Show resolved
Hide resolved
nsdeschenes
reviewed
Dec 11, 2025
Contributor
nsdeschenes
left a comment
There was a problem hiding this comment.
One small comment about clean up 👀
static/app/views/dashboards/widgetBuilder/components/widgetBuilderSlideout.tsx
Outdated
Show resolved
Hide resolved
nsdeschenes
approved these changes
Dec 11, 2025
nikkikapadia
approved these changes
Dec 11, 2025
Member
nikkikapadia
left a comment
There was a problem hiding this comment.
draggable widget stuff lgtm!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #104627, the contents of the Widget Builder are "deferred", which means that the panel opens up early, and the contents render while it's animating. Unfortunately by default, the panel is blank while loading.
This PR adds a loading skeleton with placeholders. I also had to change how we set up the intersection observers. In short, we can't use normal refs anymore because the containers for the chart mount late. Instead, I'm using callback refs, which fire once the elements are mounted.
e.g.,
Screen.Recording.2025-12-10.at.1.29.19.PM.mov
This PR is best enjoyed with whitespace off!