feat(billing): Migrate chart functions to use DATA_CATEGORY_INFO formatting #104688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d531c8 to
923605e
Compare
923605e to
6f51ba9
Compare
Comment on lines
+156
to
+159
| const categoryInfo = getCategoryInfoFromPlural(dataCategory); | ||
| const unitType = categoryInfo?.formatting.unitType ?? 'count'; | ||
|
|
||
| if (unitType !== 'bytes') { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
… formatting - Update formatReservedWithUnits to use formatting.unitType instead of isByteCategory() check - Update formatUsageWithUnits to use formatting.unitType instead of isByteCategory() and isContinuousProfiling() checks - Update convertUsageToReservedUnit to use formatting.unitType - Remove unused imports of isByteCategory and isContinuousProfiling Part of BIL-952: Move formatting functions to DATA_CATEGORY_INFO
6f51ba9 to
33e7d8b
Compare
vbro
approved these changes
Dec 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/getsentry/issue/BIL-1813/stack-3-migrate-format-functions-to-use-formatting-config
Continues from #104025