-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(code-review): Add Seer onboarding/settings status endpoint #104636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 11 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
|
@sentry review |
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
|
@sentry review |
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
JoshFerge
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API changes LGTM, will let someone else chime in on business logic
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
suejung-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, this will be really useful
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
src/sentry/seer/endpoints/organization_seer_onboarding_check.py
Outdated
Show resolved
Hide resolved
|
@suejung-sentry @JoshFerge yeah I think we are good with the current rate limits, they're the same as in organization_seer_setup_check.py and group_autofix_setup_check.py |
Fixes CW-27
Add a Seer onboarding/settings status endpoint
OrganizationSeerOnboardingCheckto be used by the onboarding wizard and in the checkout page.Response format:
hasSupportedScmIntegration: Check if the organization has an active GitHub or GitHub Enterprise integration.isCodeReviewEnabled: Check if code review is enabled for any active repository in the organization. This setting will live in the newRepositorySeerSettingsmodel.isAutofixEnabled: Check if autofix/RCA automation is enabled for any active project in the organization, ie, if any project hassentry:autofix_automation_tuningnot set to"off"or null.isSeerConfigured:hasSupportedScmIntegration and (isCodeReviewEnabled or isAutofixEnabled)