Skip to content

feat(dashboards): enable new visulization widget for span widgets #104337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DominikB2014 merged 2 commits into from
Dec 4, 2025
Merged

feat(dashboards): enable new visulization widget for span widgets #104337

DominikB2014 merged 2 commits into from
Dec 4, 2025

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Dec 3, 2025

Enable new visualization widget with spans dataset

Tested in a few places, here's an example in queries
image

@DominikB2014 DominikB2014 requested review from a team as code owners December 3, 2025 18:43
@linear
Copy link

linear bot commented Dec 3, 2025

BROWSE-85 Spans Widgets use TimeSeriesVisualization

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 3, 2025
sentry[bot]
sentry bot reviewed Dec 3, 2025
View reviewed changes
static/app/utils/timeSeries/transformLegacySeriesToPlottables.tsx
data: series.data.map(dataUnit => [
typeof dataUnit.name === 'number'
? dataUnit.name
? dataUnit.name / 1000

This comment was marked as outdated.

Sign in to view

Copy link
Contributor

@edwardgou-sentry edwardgou-sentry Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and seems to work fine for release widgets

@codecov
Copy link

codecov bot commented Dec 3, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12782 1 12781 10
View the top 1 failed test(s) by shortest run time 
transformLegacySeriesToPlottables transforms session series data correctly
Stack Traces | 0.023s run time 
Error: expect(received).toEqual(expected) // deep equality

- Expected  - 2
+ Received  + 2

  Array [
    Object {
      "incomplete": false,
-     "timestamp": 172979640000,
+     "timestamp": 172979640,
      "value": 100,
    },
    Object {
      "incomplete": false,
-     "timestamp": 172980000000,
+     "timestamp": 172980000,
      "value": 200,
    },
  ]
    at Object.toEqual (.../utils/timeSeries/transformLegacySeriesToPlottables.spec.tsx:89:49)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

edwardgou-sentry
edwardgou-sentry approved these changes Dec 3, 2025
View reviewed changes
static/app/utils/timeSeries/transformLegacySeriesToPlottables.tsx
data: series.data.map(dataUnit => [
typeof dataUnit.name === 'number'
? dataUnit.name
? dataUnit.name / 1000
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and seems to work fine for release widgets

@DominikB2014 DominikB2014 enabled auto-merge (squash) December 4, 2025 15:26
@DominikB2014 DominikB2014 disabled auto-merge December 4, 2025 15:29
@DominikB2014 DominikB2014 enabled auto-merge (squash) December 4, 2025 15:29
@DominikB2014 DominikB2014 merged commit 5409b53 into master Dec 4, 2025
48 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/browse-85-spans-widgets-use-timeseriesvisualization branch December 4, 2025 15:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sentry sentry[bot] sentry[bot] left review comments

@edwardgou-sentry edwardgou-sentry edwardgou-sentry approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DominikB2014 @edwardgou-sentry