feat(explore): set default chart interval to highest granularity #104283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
useChartInterval() will now default to the highest granularity available using ChartIntervalUnspecifiedStrategy.USE_SMALLEST.
4bd87c6 to
79b4c91
Compare
bcoe
commented
Dec 2, 2025
| end: '2024-01-01T01:00:00.000Z', | ||
| range: '1h', | ||
| environment: ['production'], | ||
| interval: '5m', |
Member
Author
There was a problem hiding this comment.
Given that logs were already setting ChartIntervalUnspecifiedStrategy.USE_SMALLEST I'm confused as to why I needed to update this test.
Would like to look a little closer before landing.
Member
Author
There was a problem hiding this comment.
useSaveAsItems, when invoking useSaveQuery uses the interval returned by userChartInterval() rather than the interval passed in as options: https://github.com/getsentry/sentry/blob/master/static/app/views/explore/hooks/useSaveQuery.tsx#L59
I believe this to be intentional so that when you save you're saving whatever is currently set in the chart on the page.
Testing locally saving queries seemed to work as expected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useChartInterval() will now default to the highest granularity available using ChartIntervalUnspecifiedStrategy.USE_SMALLEST.