feat(explore-attr-breakdowns): Cosolidating code #104194
Conversation
|
|
||
| return [ | ||
| '<div', | ||
| ' data-explore-chart-selection-region', |
There was a problem hiding this comment.
Bug: Shared tooltip adds unintended attribute to distribution chart
The shared tooltipActionsHtmlRenderer now applies data-explore-chart-selection-region to all tooltip actions. This changes the attributeDistributionChart's behavior, as it previously didn't have this attribute. Clicking its tooltip actions now prevents chart selections from clearing, which wasn't the case before.
| const roundsToWhole = rounded.endsWith('.0') || !rounded.includes('.'); | ||
|
|
||
| const decimals = roundsToWhole ? 0 : 1; | ||
| return `${percentage.toFixed(decimals)}%`; |
There was a problem hiding this comment.
Bug: Percentage formatter logic changes output for some values
The percentageFormatter logic was changed in a way that produces different output for some values. The original used percentage % 1 === 0 to determine if a number is a whole number, which only matched exact whole numbers. The new logic checks if toFixed(1) ends with ".0", which matches any value that rounds to a whole number. For example, 50.04 previously displayed as "50.0%" but now displays as "50%". This contradicts the PR's claim of "No change in functionality".
Note: No change in functionality! just some minor style changes
Added shared components to
styles.tsxAdded shared constants to
constants.tsx