Skip to content

feat(aci): Add metric issue event details #103995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
malwilley merged 7 commits into from
Dec 2, 2025
Merged

feat(aci): Add metric issue event details #103995

malwilley merged 7 commits into from
Dec 2, 2025

Conversation

@malwilley
Copy link
Member

@malwilley malwilley commented Nov 25, 2025

Adds something to the metric issue event details so it doesn't look so broken and tells the user why it triggered. Much more to add in the future, but this is a start

CleanShot 2025-11-25 at 11 10 10@2x

@malwilley malwilley requested review from a team as code owners November 25, 2025 19:11
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2025
scttcper
scttcper reviewed Nov 25, 2025
View reviewed changes
static/app/views/issueDetails/groupEventDetails/groupEventDetailsContent.tsx Outdated
</ErrorBoundary>
</Fragment>
)}
{issueTypeConfig.metricDetectorTriggered.enabled && (
Copy link
Member

@scttcper scttcper Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we don't need this, since we check that the event has a specific property

Copy link
Member

@scttcper scttcper Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've been trying to use the event to decide what to render where possible

Copy link
Member Author

@malwilley malwilley Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay yeah good call, using the data source type now to make the determination

@codecov
Copy link

codecov bot commented Dec 1, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
12734 1 12733 10
View the top 1 failed test(s) by shortest run time 
MetricDetectorTriggeredSection renders metric detector details with static condition
Stack Traces | 0.058s run time 
TestingLibraryElementError: Unable to find an accessible element with the role "region" and name "Condition"

Here are the accessible roles:

  region:

  Name "Message":
  ...

  Name "Triggered Condition":
  ...

  --------------------------------------------------
  button:

  Name "Collapse Message Section":
  ...

  Name "Collapse Triggered Condition Section":
  ...

  --------------------------------------------------
  presentation:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  img:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  group:

  Name "Collapse Message Section":
  ...

  Name "Collapse Triggered Condition Section":
  ...

  --------------------------------------------------
  separator:

  Name "":
  ...

  Name "":
  ...

  --------------------------------------------------
  table:

  Name "":
  ...

  --------------------------------------------------
  rowgroup:

  Name "":
  ...

  --------------------------------------------------
  row:

  Name "Aggregate count()":
  ...

  Name "Query is:unresolved":
  ...

  Name "Interval 1 minute":
  ...

  Name "Condition Above 100":
  ...

  Name "Evaluated Value 150":
  ...

  --------------------------------------------------
  cell:

  Name "Aggregate":
  ...

  Name "count()":
  ...

  Name "Query":
  ...

  Name "is:unresolved":
  ...

  Name "Interval":
  ...

  Name "1 minute":
  ...

  Name "Condition":
  ...

  Name "Above 100":
  ...

  Name "Evaluated Value":
  ...

  Name "150":
  ...

  --------------------------------------------------

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/node_modules/.pnpm/@testing-library+dom@10.4.0/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.getByRole (.../streamline/sidebar/metricDetectorTriggeredSection.spec.tsx:101:19)
    at Promise.finally.completed (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1559:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1499:10)
    at _callCircusTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1009:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:949:3)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:839:13)
    at _runTestsForDescribeBlock (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:829:11)
    at run (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:757:3)
    at runAndTransformResultsToJestFormat (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/jestAdapterInit.js:1920:21)
    at jestAdapter (.../sentry/node_modules/.pnpm/jest-circus@30.0.4_babel-plugin-macros@3.1..../jest-circus/build/runner.js:101:19)
    at runTestInternal (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:272:16)
    at runTest (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:340:7)
    at Object.worker (.../sentry/node_modules/.pnpm/jest-runner@30.0..../jest-runner/build/testWorker.js:494:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@malwilley malwilley merged commit 96fec29 into master Dec 2, 2025
48 checks passed
@malwilley malwilley deleted the malwilley/feat/add-metric-issue-event-details branch December 2, 2025 19:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sentry sentry[bot] sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@scttcper scttcper scttcper approved these changes

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@malwilley @scttcper