feat(perforce): Add Perforce integration infrastructure and stubs #103287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #103287 +/- ##
===========================================
+ Coverage 80.39% 80.58% +0.18%
===========================================
Files 9261 9265 +4
Lines 395395 395539 +144
Branches 25207 25207
===========================================
+ Hits 317888 318744 +856
+ Misses 77077 76365 -712
Partials 430 430 |
a978a06 to
1197dcd
Compare
billfreist
suggested changes
Nov 17, 2025
Christinarlong
approved these changes
Nov 17, 2025
Contributor
Christinarlong
left a comment
There was a problem hiding this comment.
Looks good to me, though did you mean to add a feature flag in this PR ?
Contributor
Author
|
@Christinarlong yes, I think to start with we should have a feature flag behind this. Any examples on how to do that for an integration? |
This PR adds the boilerplate and infrastructure for Perforce/Helix Core integration: - Type definitions: Added PERFORCE to ExternalProviders and IntegrationProviderSlug - Model updates: Added Perforce to external actor provider choices - Integration registration: Registered PerforceIntegrationProvider - Feature flag: Added organizations:integrations-perforce - Dependencies: Added p4python package - Stub implementations: Created empty Perforce integration, client, and repository classes with all method signatures All methods are stubbed out with proper type hints and docstrings. Implementation will be added in a follow-up PR.
a31dd31 to
62533f9
Compare
This was referenced Nov 19, 2025
GabeVillalobos
requested changes
Nov 19, 2025
Member
GabeVillalobos
left a comment
There was a problem hiding this comment.
Only blocking this for the security question on the p4python lib. Everything else seems reasonable.
src/sentry/integrations/api/endpoints/organization_code_mappings.py
Outdated
Show resolved
Hide resolved
GabeVillalobos
approved these changes
Nov 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the boilerplate and infrastructure for Perforce/Helix Core integration:
All methods are stubbed out with proper type hints and docstrings. Implementation will be added in a follow-up PR.