Skip to content

Conversation

@vbro
Copy link
Contributor

@vbro vbro commented Nov 11, 2025

This PR is stack on top of #103118 and is a follow up to https://github.com/getsentry/getsentry/pull/18799

@vbro vbro requested a review from a team November 11, 2025 00:31
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 11, 2025
{customer.dataRetention || '90d'}
{customer.orgRetention?.standard
? `${customer.orgRetention?.standard}d`
: '90d'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the reason we fallback to 90d?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This is actually an existing bug, because we show 90-day retention for free orgs.
It should fall back to the errors retention for the org (all plans have DataCategory.ERROR), and then perhaps fall back to 90.

@vbro vbro requested a review from a team as a code owner November 20, 2025 21:55
@vbro vbro requested a review from a team November 20, 2025 21:55
@vbro vbro requested review from a team as code owners November 20, 2025 21:55
@vbro vbro requested a review from a team November 20, 2025 21:55
@vbro vbro requested review from a team as code owners November 20, 2025 21:55
@vbro vbro requested review from a team and isabellaenriquez and removed request for a team November 20, 2025 22:20
@vbro vbro merged commit 81e5f8d into master Nov 25, 2025
47 checks passed
@vbro vbro deleted the vbro_use_orgretention_in_cust_overview branch November 25, 2025 22:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants