centralize event and group types + event types

dashed · dashed · commit d9c2bb20c200 · 2019-07-22T16:06:47.000-04:00
diff --git a/src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx b/src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx
@@ -5,7 +5,7 @@ import styled, {css} from 'react-emotion';
 import classNames from 'classnames';
 import {capitalize} from 'lodash';
 
-import {Metadata} from 'app/sentryTypes';
+import SentryTypes from 'app/sentryTypes';
 import EventOrGroupTitle from 'app/components/eventOrGroupTitle';
 import Tooltip from 'app/components/tooltip';
 import {getMessage, getLocation} from 'app/utils/events';
@@ -17,23 +17,7 @@ class EventOrGroupHeader extends React.Component {
   static propTypes = {
     params: PropTypes.object,
     /** Either an issue or event **/
-    data: PropTypes.shape({
-      id: PropTypes.string,
-      level: PropTypes.string,
-      type: PropTypes.oneOf([
-        'error',
-        'csp',
-        'hpkp',
-        'expectct',
-        'expectstaple',
-        'default',
-        'transaction',
-      ]).isRequired,
-      title: PropTypes.string,
-      metadata: Metadata,
-      groupID: PropTypes.string,
-      culprit: PropTypes.string,
-    }),
+    data: PropTypes.oneOfType([SentryTypes.Event, SentryTypes.Group]),
     includeLink: PropTypes.bool,
     hideIcons: PropTypes.bool,
     hideLevel: PropTypes.bool,
diff --git a/src/sentry/static/sentry/app/sentryTypes.jsx b/src/sentry/static/sentry/app/sentryTypes.jsx
@@ -148,6 +148,16 @@ export const Member = PropTypes.shape({
   user: User,
 });
 
+const EventOrGroupType = PropTypes.oneOf([
+  'error',
+  'csp',
+  'hpkp',
+  'expectct',
+  'expectstaple',
+  'default',
+  'transaction',
+]);
+
 export const Group = PropTypes.shape({
   id: PropTypes.string.isRequired,
   annotations: PropTypes.array,
@@ -174,7 +184,7 @@ export const Group = PropTypes.shape({
   status: PropTypes.string,
   statusDetails: PropTypes.object,
   title: PropTypes.string,
-  type: PropTypes.oneOf(['error', 'csp', 'default', 'transaction']),
+  type: EventOrGroupType,
   userCount: PropTypes.number,
 });
 
@@ -212,7 +222,7 @@ export const Event = PropTypes.shape({
       value: PropTypes.string,
     })
   ),
-  type: PropTypes.oneOf(['error', 'csp', 'default', 'transaction']),
+  type: EventOrGroupType,
   user: PropTypes.object,
 });
 
